Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/web: /health - and support for HTML & Plaintext #11552

Merged
merged 2 commits into from
Dec 15, 2023
Merged

core/web: /health - and support for HTML & Plaintext #11552

merged 2 commits into from
Dec 15, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 12, 2023 •
edited
Loading

The shape of our internal service architecture is not very visible. We have a fully qualified service id that we use in our logs and our health metrics, but it is still difficult to get a high level view of what is going on, or even just running.
We have a /health endpoint that returns compact JSON. This PR extends support for returning HTML or plaintext as well.

Screenshot from 2023-12-12 17-02-52

image

Requires:

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@jmank88 jmank88 force-pushed the html-health branch 2 times, most recently from 64ffd6c to 1f06834 Compare December 12, 2023 22:59
@jmank88 jmank88 changed the title WIP core/web: fix /health and support for HTML & Plaintext Dec 12, 2023
@jmank88 jmank88 requested review from krehermann, patrickhuie19 and a team December 12, 2023 23:00
@jmank88 jmank88 force-pushed the html-health branch 2 times, most recently from 6f31567 to 1ee810d Compare December 12, 2023 23:56
@jmank88 jmank88 changed the title core/web: fix /health and support for HTML & Plaintext core/web: /health - and support for HTML & Plaintext Dec 13, 2023
@jmank88 jmank88 requested a review from a team December 13, 2023 15:30
samsondav
samsondav approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea

@jmank88 jmank88 marked this pull request as ready for review December 15, 2023 20:06
@jmank88 jmank88 requested a review from jkongie as a code owner December 15, 2023 20:06
@jmank88 jmank88 requested a review from a team December 15, 2023 20:06
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.3% 88.3% Coverage
0.0% 0.0% Duplication

@jmank88 jmank88 added this pull request to the merge queue Dec 15, 2023
Merged via the queue into develop with commit b12329e Dec 15, 2023
84 checks passed
@jmank88 jmank88 deleted the html-health branch December 15, 2023 23:44
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 left review comments

@krehermann krehermann krehermann left review comments

@samsondav samsondav samsondav approved these changes

@jkongie jkongie Awaiting requested review from jkongie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmank88 @samsondav @krehermann @patrickhuie19